search

jlambert121 / jlambert121-kibana

Puppet module to install and configure kibana 4
Other
11 stars 50 forks source link

sheild ssl + credentials pickup from pabrahamsson #60

Closed bilsch closed 8 years ago

bilsch commented 9 years ago

https://github.com/evenup/evenup-kibana/pull/48 is the original pull request. I was having problems getting the merge to go cleanly so just manually re-crafted. Props for the code should go to pabrahamsson

Main changes not in pabrahamsson change set was a lint change for manifests/service.pp. I changed the kibana_elasticsearchusername ... and stripped off the kibana prefix, overly wordy IMO.

rake test results from local

 rake test
---> syntax:manifests
---> syntax:templates
---> syntax:hiera:yaml
metadata-json-lint metadata.json
metadata-json-lint metadata.json
Notice: Preparing to install into /Users/bschwanitz/gits/cmm/evenup-kibana/spec/fixtures/modules ...
Notice: Downloading from https://forgeapi.puppetlabs.com ...
Notice: Installing -- do not interrupt ...
/Users/bschwanitz/gits/cmm/evenup-kibana/spec/fixtures/modules
└── maestrodev-wget (v1.7.1)
Notice: Preparing to install into /Users/bschwanitz/gits/cmm/evenup-kibana/spec/fixtures/modules ...
Notice: Downloading from https://forgeapi.puppetlabs.com ...
Warning: Symlinks in modules are unsupported. Please investigate symlink puppetlabs-stdlib-4.2.0/spec/acceptance/nodesets/default.yml->centos-64-x64.yml.
Notice: Installing -- do not interrupt ...
/Users/bschwanitz/gits/cmm/evenup-kibana/spec/fixtures/modules
└── puppetlabs-stdlib (v4.2.0)
/Users/bschwanitz/.rbenv/versions/2.1.2/bin/ruby -I/Users/bschwanitz/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/rspec-support-3.1.2/lib:/Users/bschwanitz/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/rspec-core-3.1.7/lib /Users/bschwanitz/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/rspec-core-3.1.7/exe/rspec --pattern spec/\{classes,defines,unit,functions,hosts,integration,types\}/\*\*/\*_spec.rb --color
WARN: Unresolved specs during Gem::Specification.reset:
      rake (>= 0)
WARN: Clearing out unresolved specs.
Please report a bug if this causes problems.
............................

Finished in 4.37 seconds (files took 1.16 seconds to load)
28 examples, 0 failures
jlambert121 commented 8 years ago

Thanks for reworking this. Closes #48