search

jlambert121 / jlambert121-kibana

Puppet module to install and configure kibana 4
Other
11 stars 50 forks source link

add plugin support #68

Closed bilsch closed 8 years ago

bilsch commented 8 years ago

hiera config to add / remove plugins also works

kibana::plugins: marvel: source: elasticsearch/marvel/latest

And to remove

kibana::plugins: marvel: source: elasticsearch/marvel/latest ensure: absent

bilsch commented 8 years ago

I'll work on getting the test suites added for this shortly

bilsch commented 8 years ago

This should be ready for review. Let me know if you want more test cases added in

bilsch commented 8 years ago

@jlambert121 mind taking a look at this?

jlambert121 commented 8 years ago

This looks great - thanks! Would you add a test for removing a plugin and squish things down to a single commit and I'll merge it?

bilsch commented 8 years ago

@jlambert121 ok tweaked the rspec tests and added the remove / absent test and squished to a single commit

jlambert121 commented 8 years ago

Thanks!