search

jlambert121 / jlambert121-puppet

Puppet module to manage puppet and puppetserver (java)
Apache License 2.0
5 stars 23 forks source link

Use the regexp data type for hiera_source #26

Closed roidelapluie closed 9 years ago

jlambert121 commented 9 years ago

I like this, travis is upset though. What version of puppet supports a Regex type?

roidelapluie commented 9 years ago

I am testing with 4.2

jlambert121 commented 9 years ago

I've bumped the module to require puppet >= 4.2, can you rebase this so we can make sure it works? I'm fine keeping this puppet module with the newest version of puppet.

roidelapluie commented 9 years ago

@jlambert121 sorry but it fails with 4.2 tests.

However "puppet parser validate" thinks it's fine. So there is a bug in the test toolchain.

roidelapluie commented 9 years ago 
$ grep Regex manifests/init.pp
  Optional[Regexp[/^puppet/]]                  $hiera_source      = $::puppet::params::hiera_source,
$ puppet parser validate manifests/init.pp
$ echo $?
0
jlambert121 commented 9 years ago

So it looks like puppet-lint needs a patch merged (https://github.com/rodjek/puppet-lint/pull/435) for this to work. I'll either disable the linter or set this up to run off of a fork. I will get it figured out tomorrow, I need to cut a release.