search

jlambert121 / jlambert121-puppet

Puppet module to manage puppet and puppetserver (java)
Apache License 2.0
5 stars 23 forks source link

Update for 2.3.0 #58

Closed rnelson0 closed 8 years ago

rnelson0 commented 8 years ago

See http://docs.puppetlabs.com/puppetserver/latest/release_notes.html#modifications-to-bootstrapcfg-might-cause-problems-during-upgrades-to-230 for more detail.

This will need a release ASAP as the current version, when using latest or 2.3.0, will result in puppetserver being reloaded and failing to start.

rnelson0 commented 8 years ago

Maybe scratch on the release, SERVER-1213 explains that there's no way to generate a file that's forward and backward compatible. It may make more sense to add a param for the user to provide their own template.

greigm commented 8 years ago

Ah, just saw this after submitting my own PR. I must be going blind in my old age... That said, I've wrapped mine in a version check which should at least do no harm to older versions.

rnelson0 commented 8 years ago

I'm not sure how to address this long term. This actually isn't the right way, since an unknown service would cause a crash on <2.3, so I'm going to close the PR. Perhaps the option to provide a template or "extra" stanzas would be sufficient. I'm open to ideas.

jlambert121 commented 8 years ago

Should we have a list of services tied to various versions of puppetserver? Seems like a bad hack that will break, but this is an annoying issue.

cprice404 commented 8 years ago

@jlambert121 you may be interested in checking out https://tickets.puppetlabs.com/browse/SERVER-1213 . We're trying to map out a way to make this situation better in future releases, so if you have any comments they'd be welcome.

jlambert121 commented 8 years ago

Thanks @cprice404 I'll check it out!