Bumped concat version dependency and added now required param in bootstrap.cfg

jlambert121 / jlambert121-puppet

Puppet module to manage puppet and puppetserver (java)

Apache License 2.0

5 stars 23 forks source link

Bumped concat version dependency and added now required param in bootstrap.cfg #59

Closed greigm closed 8 years ago

greigm commented 8 years ago

bootstrap.cfg check might need work for PE versions. My method is tested/working on current 4.4.0 OSS release (as determined by $::puppetversion - I really wish PuppetLabs would standardise versioning across components).

Anyway, this should work, or at least do no harm as is. I'm sure there's a much better way, but time is a bit tight.

jlambert121 commented 8 years ago

One issue I can think of is if you use puppet to upgrade puppet (from pre-4.4.0 to post 4.4.0) this will break since the fact would have been generated before the service was upgraded. Do we need to require a puppet version to be set on this module so we know what version to configure for?

greigm commented 8 years ago

Indeed. There are a ton of reasons why this is probably a bad idea. I needed to run from the fork though, so thought I might as well generate the PR as something to think about. I'll close it.