search

jlandon / Alexandria

A library of Swift extensions to turbocharge your iOS development.
https://jlandon.github.io/Alexandria
MIT License
65 stars 8 forks source link

Add UIFont.getCustomFont(filePath:, ofSize) method. #37

Closed sapzildj closed 7 years ago

sapzildj commented 7 years ago

Thanks for providing an useful framework!

This request would be helpful when using a downloaded font and more convenient because not needed explicit registering.

jlandon commented 7 years ago

Hey @sapzildj,

Thanks for adding this functionality! Only change I'd suggest is an update to the getCustomFont method signature. Swift doesn't use the set/get naming convention for functions, so I would update that method signature to:

static func customFont(filePath: String, ofSize fontSize: CGFloat) -> UIFont?
sapzildj commented 7 years ago

Hi, @jlandon.

I've changed method name!

jlandon commented 7 years ago

@sapzildj sorry for just getting around to this now. Thanks again for working on this!