search

jlas1 / Klicky-Probe

Microswitch probe with magnetic attachement, primarily aimed at CoreXY 3d printers
GNU General Public License v3.0
1.22k stars 279 forks source link

Change macros to support minimum_cruise_ratio instead of max_accel_to_decel #243

Closed Senorgif2 closed 5 months ago

Senorgif2 commented 5 months ago

Per Klipper changes; max_accel_to_decel has been deprecated. Klicky macros provided in this depository no longer function reporting Error on "'SET_VELOCITY_LIMIT ACCEL_TO_DECEL=': unable to parse"

jlas1 commented 5 months ago

thanks, i'll check this out

On Thu, 14 Mar 2024 at 21:20, Senorgif2 @.***> wrote:

Per Klipper changes; max_accel_to_decel has been deprecated. Klicky macros provided in this depository no longer function reporting Error on "'SET_VELOCITY_LIMIT ACCEL_TO_DECEL=': unable to parse"

— Reply to this email directly, view it on GitHub https://github.com/jlas1/Klicky-Probe/issues/243, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD7HHCVJVYQIOBOILHVEWFTYYIIAJAVCNFSM6AAAAABEW3WMJWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGE4DOMRYGY2TAMY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

patofoto commented 5 months ago

Same issue. Any resolution yet?.

alexyubin commented 5 months ago

Same issue.

itsgudenuf commented 5 months ago

I tried the change in commit d2c91ba and it seems to at least get around the problem for now.

jlas1 commented 5 months ago

it's solved now, removing the setting is safe to do and won't force people to use the latest klipper version.