Use completed_labels argument (instead of global variable)

jlaska / pytest-github

Plugin for py.test that associates tests with github issues using a marker

MIT License

18 stars 9 forks source link

Use completed_labels argument (instead of global variable) #11

Closed jladdjr closed 6 years ago

jladdjr commented 6 years ago

GITHUB_COMPLETED_LABELS is currently used instead of the completed_labels argument passed to GitHubPytestPlugin's constructor.

The default value for GITHUB_COMPLETED_LABELS is []. This has the effect of making all issues effectively unresolved. As a result, all github-marked tests are xpassed or xfailed (never passed or failed). This will mask any tests that should pass / fail after an issue has been resolved.

coveralls commented 6 years ago

Coverage remained the same at 95.833% when pulling bb41a3c1d9f41e0dfc97050da3ee0dad1c275f9d on jladdjr:use_github_completed_argument_not_global_var into 1b85fb9a5b2fe946d0a520dee3667c5a56db6f97 on jlaska:master.