search

jlaska / pytest-github

Plugin for py.test that associates tests with github issues using a marker
MIT License
18 stars 9 forks source link

Update failing tests #18

Closed kdelee closed 6 years ago

kdelee commented 6 years ago

It appears that --github-token, --github-username are not being passed around correctly and this is leading to a null object from:

https://github.com/jlaska/pytest-github/blob/a44116dec18c4bfcf4eaa8f8d8496e2f5cbbca1c/pytest_github/plugin.py#L232

https://github.com/jlaska/pytest-github/blob/a44116dec18c4bfcf4eaa8f8d8496e2f5cbbca1c/pytest_github/plugin.py#L215 expects a password, but when it is called it is ostensibly provided a token

https://github.com/jlaska/pytest-github/blob/a44116dec18c4bfcf4eaa8f8d8496e2f5cbbca1c/pytest_github/plugin.py#L116

Need to dig into this more and fix these tests or update them to reflect actual usage

kdelee commented 6 years ago

I'll work on this -- can't assign myself because I don't have correct access.

We could also consider migrating this to ansible namespace, but that is a nother issue altogether.

kdelee commented 6 years ago

Well, my original hypothesis was wrong -- but I got the tests updated never the less! see https://github.com/jlaska/pytest-github/pull/19

kdelee commented 6 years ago

this can get closed now :)