jlaska / pytest-github

Plugin for py.test that associates tests with github issues using a marker
MIT License
18 stars 9 forks source link

fix github marker collection for test runs involving multiple modules #2

Closed jakemcdermott closed 8 years ago

jakemcdermott commented 8 years ago

Summary

The PR fixes a bug that is causing github markers to not be collected for test runs involving multiple test modules.

The github issue cache was being initialized from within the pytest_collectstart hook, which is invoked at least once for each collected test module. This caused the collection of github issues to be discarded multiple times during the test collection process.

Bug Details

Steps to Reproduce:

Expected Results:

Actual Results:

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 9504ad8ff5c2a8c70a5482ffd8433486d20ed7df on jakemcdermott:fix_multiple_file_marker_collection into 04b5285f0000acb7b6bb45b1dde0b9650f90b221 on jlaska:master.

jlaska commented 8 years ago

which is invoked at least once for each collected test module.

Aha! Great find, and thanks for the PR. Merging.