jlaska / pytest-github

Plugin for py.test that associates tests with github issues using a marker
MIT License
18 stars 9 forks source link

terminalreporter not configured for xdist processes #3

Closed rmfitzpatrick closed 8 years ago

rmfitzpatrick commented 8 years ago

This will prevent pytest-github from failing out of runs using pytest-xdist:

INTERNALERROR>   File ".../python2.7/site-packages/pytest_github/plugin.py", line 225, in pytest_collection_modifyitems
INTERNALERROR>     reporter.write_line("collected {0} github issues".format(len(self._issue_cache)), bold=True)
INTERNALERROR> AttributeError: 'NoneType' object has no attribute 'write_line'
jlaska commented 8 years ago

@rmfitzpatrick can you rebase to pull in a fix on master that should resolve the unittest failure?

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 1b9542d0868be6fef432acefa79cdadbf76112e5 on rmfitzpatrick:terminal_reporter_not_supported_by_xdist into 004be4069782c3dbd6ebe2d1e71c753b921ed847 on jlaska:master.

jlaska commented 8 years ago

@rmfitzpatrick thanks for the contribution! Merging.