Why does notetaker_notes table also holds modid

jlb224 / moodle-mod_notetaker

Notetaker plugin for Moodle - allows students to take public or private notes within a course.

https://jlb224.github.io/moodle-mod_notetaker/

Other

2 stars 4 forks source link

Why does notetaker_notes table also holds modid #4

Closed mudrd8mz closed 3 years ago

mudrd8mz commented 4 years ago

The notetaker_notes has a foreign key notetakerid that creates the 1:N relation between notetaker instance and notetaker_notes. But then the notetaker_notes also has another field that links to the same notetaker instance.

This violates the https://en.wikipedia.org/wiki/Third_normal_form and should be avoided - unless I am missing something?

jlb224 commented 3 years ago

Resolved. Code refactored to remove unnecessary modid column