jlchan / StartUpDG.jl

Initializes and sets up reference elements and physical meshes for DG.
MIT License
27 stars 9 forks source link

fix allocations coming from `num_elements` #120

Closed ranocha closed 1 year ago

ranocha commented 1 year ago

Fixes https://github.com/trixi-framework/Trixi.jl/issues/1435 on Julia v1.9.0-rc3.

codecov[bot] commented 1 year ago

Codecov Report

Merging #120 (d1bc399) into main (fbc55b9) will not change coverage. The diff coverage is 72.72%.

@@           Coverage Diff           @@
##             main     #120   +/-   ##
=======================================
  Coverage   96.19%   96.19%           
=======================================
  Files          25       25           
  Lines        2842     2842           
=======================================
  Hits         2734     2734           
  Misses        108      108           
Impacted Files Coverage Δ
src/MeshData.jl 94.62% <72.72%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

ranocha commented 1 year ago

I don't see what fails on Windows...

jlchan commented 1 year ago

@ranocha thanks for catching that! I'm rerunning the failed windows test, but otherwise LGTM.

jlchan commented 1 year ago

Closing in favor of https://github.com/jlchan/StartUpDG.jl/pull/121