search

jlchan / StartUpDG.jl

Initializes and sets up reference elements and physical meshes for DG.
MIT License
27 stars 9 forks source link

Make triangle and tet node orderings consistent #153

Closed jlchan closed 7 months ago

jlchan commented 8 months ago

The tet node ordering is such that the fastest index is the x-index i, then the y-index j, then the z-index k. For some reason, the triangle ordering had the y-index j as the fastest index, and then the x-index i. This is inconsistent, and also makes it harder to use StartUpDG.jl in conjunction with T8code.jl.

This PR fixes the triangle node ordering, as well as the wedge ordering (since it is tied to the triangle node ordering). This should be released as a breaking change, and will require https://github.com/jlchan/NodesAndModes.jl/pull/14 to be merged first (and for a new breaking version of NodesAndModes.jl to be released).

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1c0cfe7) 96.81% compared to head (99f7971) 96.80%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #153 +/- ## ========================================== - Coverage 96.81% 96.80% -0.01% ========================================== Files 26 26 Lines 3325 3321 -4 ========================================== - Hits 3219 3215 -4 Misses 106 106 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.