Closed jlchan closed 5 months ago
Attention: Patch coverage is 98.33333%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 96.84%. Comparing base (
4fd36c7
) to head (1501989
).:exclamation: Current head 1501989 differs from pull request most recent head 1e5796f. Consider uploading reports for the commit 1e5796f to get more accurate results
Files | Patch % | Lines |
---|---|---|
src/RefElemData.jl | 80.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
To clean up the Polynomial
approximation type, we'll take the following steps:
TensorProductQuadrature
on Quad
and Hex
elementsMultidimensionalQuadrature
instead of DefaultPolynomialType
to distinguish from TensorProductQuadrature
. DefaultPolynomialType
is now only be used for dispatch to select between MultidimensionalQuadrature
and TensorProductQuadrature
.
Currently dispatch on
approximation_type
is messy and makes it hard to add structure based on quadrature structure (e.g., Stroud tensor product quadrature).This PR reorganizes
RefElemData
so that quadrature information goes into thePolynomial
approximation type. This is consistent with the current approach taken bySBP
approximation type, which also encodes specific information about the quadrature used to construct operators.