StartUpDG t8code todo list

jlchan / StartUpDG.jl

Initializes and sets up reference elements and physical meshes for DG.

MIT License

28 stars 9 forks source link

StartUpDG t8code todo list #38

Open jlchan opened 1 year ago

jlchan commented 1 year ago

@Davknapp @jmark from our Trixi discussion

[x] Generalize connectivity in MeshData (remove mapP, mapB as fields, replace with a general "node connectivity" field to enable t8code). Note: this should be non-breaking, since we can simply overload getproperties to ensure md.mapP still returns the relevant array.
[ ] Add ability to create connectivities between different MeshData objects.

If there is anything else you can think of, please feel free to add those items.

jmark commented 1 year ago

@jlchan Can you imagine a MeshData constructor which accepts a list of face connectivity (with orientation ;) and a list of physical points and Jacobians evaluated on quadrature points per element?

jlchan commented 1 year ago

Certainly. I don't need the orientation for my own constructor but I can certainly store it.

Are the physical points interpolation points or quadrature points? I would prefer interpolation points if possible (easier to enforce a watertight mesh).

jmark commented 1 year ago

Sure, interpolation points will work.

Yeah, I think we have to pass the orientation to the user to take care of it so that the interpolated face values from each side correctly match according to the mesh.

jlchan commented 1 year ago

Sounds good. FYI, we account for orientation when computing the mapP array - any changes in orientation are accounted for in the ordering of the node maps, and these node maps are just computed based on node positions (if two nodes basically have the same coordinates, we map one to the other).