search

jlchan / StartUpDG.jl

Initializes and sets up reference elements and physical meshes for DG.
MIT License
27 stars 9 forks source link

load Plots via Requires also on Julia 1.9 #80

Closed ranocha closed 1 year ago

ranocha commented 1 year ago

Locally, this fixes #79 for me.

However, I have no idea why it didn't work when loading Plots as weak dependency...

codecov[bot] commented 1 year ago

Codecov Report

Merging #80 (2db910e) into main (65ba381) will increase coverage by 0.04%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
+ Coverage   96.64%   96.69%   +0.04%     
==========================================
  Files          21       21              
  Lines        2294     2297       +3     
==========================================
+ Hits         2217     2221       +4     
+ Misses         77       76       -1
Impacted Files Coverage Δ
src/TriangulatePlots.jl 96.00% <ø> (ø)
src/StartUpDG.jl 100.00% <100.00%> (+25.00%) :arrow_up:
src/mesh/triangulate_example_meshes.jl 100.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

jlchan commented 1 year ago

Thanks! Looks great, no idea why we need Plots thru Requires either...