jlchan / StartUpDG.jl

Initializes and sets up reference elements and physical meshes for DG.
MIT License
27 stars 9 forks source link

Write vtk #81

Closed Davknapp closed 1 year ago

Davknapp commented 1 year ago

Use WriteVTK to write meshes. To be able to represent the polynomials on the elements we use the lagrangian elements of vtk.

In a first step we compute the permutation between the order of nodes in StartUpDG and vtk. We can then write them using that permutation.

Extracare is taken for the position of the nodes, since vtk assumes equidistant nodes.

codecov[bot] commented 1 year ago

Codecov Report

Merging #81 (c1b0f09) into main (376e1e6) will decrease coverage by 0.11%. The diff coverage is 97.05%.

@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
- Coverage   96.61%   96.51%   -0.11%     
==========================================
  Files          21       22       +1     
  Lines        2304     2379      +75     
==========================================
+ Hits         2226     2296      +70     
- Misses         78       83       +5     
Impacted Files Coverage Δ
src/StartUpDG.jl 100.00% <ø> (ø)
src/mesh/mesh_visualization.jl 93.22% <90.47%> (-1.52%) :arrow_down:
src/mesh/vtk_helper.jl 100.00% <100.00%> (ø)
src/cut_cell_meshes.jl 97.51% <0.00%> (-0.52%) :arrow_down:
src/MeshData.jl 93.54% <0.00%> (-0.51%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

jlchan commented 1 year ago

@Davknapp looks good! Only one question - can we avoid exporting match_coordinate_vectors and match_coordinate_vectors!? Otherwise, ready to merge.

jlchan commented 1 year ago

@Davknapp ready to merge?

Davknapp commented 1 year ago

@Davknapp ready to merge?

Ready to merge!