jlchan / StartUpDG.jl

Initializes and sets up reference elements and physical meshes for DG.
MIT License
27 stars 9 forks source link

Add quads to vtk writer #83

Closed Davknapp closed 1 year ago

Davknapp commented 1 year ago

Add Quads to the vtk-writer. Similar to the triangle-vtk-writer.

jlchan commented 1 year ago

@Davknapp it looks like this has some conflicts, and seems to duplicate some of the changes made in #81 too. Is there any way to fix this? For example, could you branch off of main now that #81 is merged and cherry pick the new commits from this PR?

Davknapp commented 1 year ago

@Davknapp it looks like this has some conflicts, and seems to duplicate some of the changes made in #81 too. Is there any way to fix this? For example, could you branch off of main now that #81 is merged and cherry pick the new commits from this PR?

I merged the current main-branch into this branch. The branch is directly build on #81 therefore it should solve the issue.

codecov[bot] commented 1 year ago

Codecov Report

Merging #83 (9257f0a) into main (a6e8684) will decrease coverage by 0.70%. The diff coverage is 94.00%.

:exclamation: Current head 9257f0a differs from pull request most recent head 086352f. Consider uploading reports for the commit 086352f to get more accurate results

@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
- Coverage   97.26%   96.56%   -0.70%     
==========================================
  Files          19       22       +3     
  Lines        2193     2417     +224     
==========================================
+ Hits         2133     2334     +201     
- Misses         60       83      +23     
Impacted Files Coverage Δ
src/RefElemData.jl 93.68% <ø> (ø)
src/RefElemData_polynomial.jl 100.00% <ø> (ø)
src/mesh/simple_meshes.jl 97.62% <0.00%> (ø)
src/mesh/triangulate_example_meshes.jl 100.00% <ø> (ø)
src/state_redistribution.jl 95.71% <72.72%> (+0.67%) :arrow_up:
src/hybrid_meshes.jl 95.12% <87.09%> (-3.11%) :arrow_down:
src/mesh/mesh_visualization.jl 93.22% <90.47%> (-1.52%) :arrow_down:
src/cut_cell_meshes.jl 97.51% <91.54%> (-1.26%) :arrow_down:
src/MeshData.jl 93.54% <92.30%> (-0.99%) :arrow_down:
src/named_array_partition.jl 94.44% <94.44%> (ø)
... and 12 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more