search

jlchan / StartUpDG.jl

Initializes and sets up reference elements and physical meshes for DG.
MIT License
28 stars 9 forks source link

fix warning when using Triangulate, StartUpDG #9

Closed ranocha closed 3 years ago

ranocha commented 3 years ago

Current master:

julia> using Triangulate, StartUpDG
[ Info: Precompiling StartUpDG [472ebc20-7c99-4d4b-9470-8fde4e9faa0f]
┌ Warning: Package StartUpDG does not have Triangulate in its dependencies:
│ - If you have StartUpDG checked out for development and have
│   added Triangulate as a dependency but haven't updated your primary
│   environment's manifest file, try `Pkg.resolve()`.
│ - Otherwise you may need to report an issue with StartUpDG
└ Loading Triangulate into StartUpDG from project dependency, future warnings for StartUpDG are suppressed.

julia>

This PR:

julia> using Triangulate, StartUpDG

julia>

It looks like I also removed some trailing whitespace (because of the default settings of my editor). If you want to keep the trailing whitespace, I can adjust this PR.

codecov[bot] commented 3 years ago

Codecov Report

Merging #9 (65fa03c) into master (28f83bf) will not change coverage. The diff coverage is 83.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #9   +/-   ##
=======================================
  Coverage   96.86%   96.86%           
=======================================
  Files          14       14           
  Lines        1021     1021           
=======================================
  Hits          989      989           
  Misses         32       32
Impacted Files Coverage Δ
src/mesh/triangulate_utils.jl 94.11% <83.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 28f83bf...65fa03c. Read the comment docs.

jlchan commented 3 years ago

Thanks for the PR! I'll release a patch update soon with this in it.