Remove instances of `@unpack`

jlchan commented 1 year ago

Since @unpack x = y is equivalent to (; x) = y in Julia 1.7 onwards, we can remove dependence on UnPack.jl.

Motivated by https://github.com/trixi-framework/Trixi.jl/pull/1367

codecov[bot] commented 1 year ago

Codecov Report

Merging #90 (236ba0c) into main (ae78647) will not change coverage. The diff coverage is 97.67%.

@@           Coverage Diff           @@
##             main      #90   +/-   ##
=======================================
  Coverage   96.86%   96.86%           
=======================================
  Files          22       22           
  Lines        2491     2491           
=======================================
  Hits         2413     2413           
  Misses         78       78

Impacted Files	Coverage Δ
src/RefElemData.jl	`93.68% <ø> (ø)`
src/StartUpDG.jl	`100.00% <ø> (ø)`
src/connectivity_functions.jl	`94.85% <66.66%> (ø)`
src/MeshData.jl	`93.54% <100.00%> (ø)`
src/RefElemData_SBP.jl	`95.65% <100.00%> (ø)`
src/cut_cell_meshes.jl	`98.06% <100.00%> (ø)`
src/geometric_functions.jl	`98.43% <100.00%> (ø)`
src/hybrid_meshes.jl	`96.74% <100.00%> (ø)`
src/mesh/mesh_visualization.jl	`94.33% <100.00%> (ø)`
src/mesh/simple_meshes.jl	`97.62% <100.00%> (ø)`
... and 3 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

jlchan commented 1 year ago

Exporting @unpack from SimpleUnpack.jl to avoid potential breaking changes.

jlchan / StartUpDG.jl

Remove instances of `@unpack` #90

Codecov Report