search

jldbc / pybaseball

Pull current and historical baseball statistics using Python (Statcast, Baseball Reference, FanGraphs)
MIT License
1.24k stars 331 forks source link

Add BRef and Retrosheet to teamid_lookup #159

Closed TheCleric closed 3 years ago

TheCleric commented 3 years ago

In response to the request that @Am3ra made in #156, this PR adds the BRef and Retrosheet IDs to the teamid_lookup module. As well it changes the name of fangraphs_teams to team_ids (while maintaining fangraphs_teams as an alias for backwards compatibility.

schorrm commented 3 years ago

This looks good to me, but honestly, tiny bit worried there's no comments / controversy etc

TheCleric commented 3 years ago

This looks good to me, but honestly, tiny bit worried there's no comments / controversy etc

What do you mean @schorrm ? My PRs NEVER have any comments. They just pop into existence as PERFECTION. Just look at the cache PR. 😉

schorrm commented 3 years ago

Lol. In general, if there's nothing, means everybody wasn't paying attn or missed something. I'll try one thing here tho: does this need a docs update?

TheCleric commented 3 years ago

Lol. In general, if there's nothing, means everybody wasn't paying attn or missed something. I'll try one thing here tho: does this need a docs update?

That's actually a good point. I'll take care of that.