get a logger instead of globally config logging

jldbc / pybaseball

Pull current and historical baseball statistics using Python (Statcast, Baseball Reference, FanGraphs)

MIT License

1.26k stars 335 forks source link

Closed Maradonna90 closed 3 years ago

Maradonna90 commented 3 years ago

fixes #199

schorrm commented 3 years ago

@TheCleric can you please take a look?

TheCleric commented 3 years ago

@TheCleric can you please take a look?

LGTM

schorrm commented 3 years ago

@Maradonna90 -- Looks good, can I just ask you to merge in the changes and push?

Maradonna90 commented 3 years ago

failed tests seem to be cache related

schorrm commented 3 years ago

Yeah, those are being dealt with. LGTM, and thanks for contributing!