jldbc / pybaseball

Pull current and historical baseball statistics using Python (Statcast, Baseball Reference, FanGraphs)
MIT License
1.23k stars 330 forks source link

Change beautiful soup parser to html.parser #219

Closed dk-sa1 closed 3 years ago

dk-sa1 commented 3 years ago

When using the batting_stats_range function, there was an error when parsing across the date '2021-06-25'.

Changing the parser in beautiful soup from lxml to html.parser appears to solve the issue.

Bug link: https://github.com/jldbc/pybaseball/issues/218

schorrm commented 3 years ago

This is not the correct approach to this -- the lxml is there because it's the fastest. I believe this is related to a structure change addressed in #215

schorrm commented 3 years ago

@dk-sa1 was this addressed by that PR?

dk-sa1 commented 3 years ago

The issue was NOT addressed by the PR #215

schorrm commented 3 years ago

Closing this in favor of #223