Closed marek-slipski closed 3 years ago
We can do this if you update the unit tests to match
I think that should do it, but let me know if I'm missing something (I'm new at this).
whoops, missed. can you merge the upstream testing changes back in and push and see if it passes the CI?
Context
Baseball-Reference player stat pages (like this) have player MLB IDs embedded in links. Scraping these IDs would be useful as
batting_stats_range
andpitching_stats_range
return a Dataframe with Baseball-Reference player names as the only identifier but these are difficult to join on. This would grab the IDs from the links and add anmlbID
column to the batting and pitching tables.Example output of![image](https://user-images.githubusercontent.com/21132266/125552198-e9ac6197-0272-45b9-a944-2550f562dcbf.png)
pitching_stats_range
: