spraychart scales - Githubissues

jldbc / pybaseball

Pull current and historical baseball statistics using Python (Statcast, Baseball Reference, FanGraphs)

MIT License

1.23k stars 330 forks source link

Closed bdilday closed 3 years ago

bdilday commented 3 years ago

Multiplies the stadium coordinates by a factor 2.495 / 2.33 to put them on same scale as the hc_x and hc_y fields from mlbam.

The scale factor was determined heuristically by:

finding the scale of STADIUM_COORDS that will match the outfield dimensions, e.g., for coors,
finding the scale for mlbam data so that hc_x, hc_y match the hit_distance_sc field
the center (x=125, y=199) comes from this hardball times article

schorrm commented 3 years ago

LGTM, can you merge up to the test fix to appease the checkmark?

schorrm commented 3 years ago

Also, does this close #224?

schorrm commented 3 years ago

Closes #224