search

jldbc / pybaseball

Pull current and historical baseball statistics using Python (Statcast, Baseball Reference, FanGraphs)
MIT License
1.23k stars 330 forks source link

Fix import statements in statcast docs #228

Closed wfordh closed 3 years ago

wfordh commented 3 years ago

Fixing issues with documentation for statcast docs brought up by #225

bdilday commented 3 years ago

I think it'd be a good idea to expose these at the top level, example, in pybaseball/__init__.py

from .statcast_batter import (
    statcast_batter,
    statcast_batter_exitvelo_barrels,
    statcast_batter_expected_stats,
    statcast_batter_percentile_ranks,
    statcast_batter_pitch_arsenal,
)
wfordh commented 3 years ago

Ah so that's why I could import statcast_batter() directly and couldn't with these. I can add the functions into pybaseball/__init__.py like that for all of them and then revert back to the original documentation

schorrm commented 3 years ago

LGTM, @bdilday all good?