search

jldbc / pybaseball

Pull current and historical baseball statistics using Python (Statcast, Baseball Reference, FanGraphs)
MIT License
1.23k stars 330 forks source link

Add a matrix to test on all python versions #232

Closed TheCleric closed 3 years ago

TheCleric commented 3 years ago

Testing out a matrix that will test changes against all current python versions.

@schorrm I think this could help catch things like what I found in #231 which was a TypeError that seems to happen in 3.7+, but not previously caught in our 3.6 tests (which you can see are causing failures below in 3.7 and 3.8).

As well we may be able to easily add 3.10 when that's ready to see how our code base will fair.

schorrm commented 3 years ago

I would prefer to not commit to supporting so many in the tests, it also has time costs

TheCleric commented 3 years ago

I would prefer to not commit to supporting so many in the tests, it also has time costs

They run in parallel, so the time cost should be minimal.

schorrm commented 3 years ago

red exs scary

TheCleric commented 3 years ago

red exs scary

They'll get fixed after the other PR gets merged (and master gets merged in here)

schorrm commented 3 years ago

Other merged, can you merge back and appease the CI?

TheCleric commented 3 years ago

@schorrm all tests passing now in case you didn't see it.