search

jldbc / pybaseball

Pull current and historical baseball statistics using Python (Statcast, Baseball Reference, FanGraphs)
MIT License
1.26k stars 333 forks source link

Several methods in the Lahman package were not working #253

Closed cj0121 closed 2 years ago

tjburch commented 2 years ago

Could you list which ones and what error messages you were encountering?

cj0121 commented 2 years ago

I'm not sure if it's a problem on my end, but the awards_managers(), awards_players(), awards_share_managers(), awards_share_managers(), college_playing(), hall_of_fame(), salaries(), and schools() functions all return an similar error message as shown in the attachment.

Also a minor suggestion: it will be tremendously helpful if all player and team data come with MLBAM id, fangraph id, or any unique identifier. It will make joining data with other data sources so much easier. Just a thought. Thanks!

Tyler Burch @.***> 于2022年4月23日周六 15:52写道：

Could you list which ones and what error messages you were encountering?

— Reply to this email directly, view it on GitHub https://github.com/jldbc/pybaseball/issues/253#issuecomment-1107639423, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWZYYHWUZ5QDZ6XZXMVKZG3VGRIGNANCNFSM5QE62ZMA . You are receiving this because you authored the thread.Message ID: @.***>

tjburch commented 2 years ago

So I don't see an attachment (guessing you commented via email and not on GitHub directly?).

I'm assuming you're running into a FileNotFoundError. The associated files to the methods you're referencing are now in .pybaseball/cache/baseballdatabank-master/contrib/, but as of last release it's looking at .pybaseball/cache/baseballdatabank-master/core/.

However, it looks like this has been resolved with #251. See : https://github.com/jldbc/pybaseball/commit/42ad7446e094e9f6818daae4b26e6ea8c309e695. So it should be resolved in the next release.

For now, you can just copy all the stuff in your /contrib/ to your /core/ directory and it should work.

cj0121 commented 2 years ago

Yes that’s the error. Thanks for the clarification.

On Sun, Apr 24, 2022 at 5:46 PM Tyler Burch @.***> wrote:

So I don't see an attachment (guessing you commented via email and not on GitHub directly?).

I'm assuming you're running into a FileNotFoundError. The associated files to the methods you're referencing are now in .pybaseball/cache/baseballdatabank-master/contrib/, but as of last release it's looking at .pybaseball/cache/baseballdatabank-master/core/.

However, it looks like this has been resolved with #251 https://github.com/jldbc/pybaseball/pull/251 : 42ad744 https://github.com/jldbc/pybaseball/commit/42ad7446e094e9f6818daae4b26e6ea8c309e695. So it should be resolved in the next release.

For now, you can just copy all the stuff in your /contrib/ to your /core/ directory and it should work.

— Reply to this email directly, view it on GitHub https://github.com/jldbc/pybaseball/issues/253#issuecomment-1107924264, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWZYYHSMDXK7SNWTAVJLHMTVGW6JPANCNFSM5QE62ZMA . You are receiving this because you authored the thread.Message ID: @.***>