jldbc / pybaseball

Pull current and historical baseball statistics using Python (Statcast, Baseball Reference, FanGraphs)
MIT License
1.19k stars 324 forks source link

Use objects qualified name in caching #269

Closed bdilday closed 2 years ago

bdilday commented 2 years ago

This adds a CI stage to illustrate the problem mentioned here https://github.com/jldbc/pybaseball/issues/267 https://github.com/jldbc/pybaseball/issues/221 namely that when the cache is enabled, the call to get the fangraphs batting and pitching stats return the same dataframe.

bdilday commented 2 years ago

Updated the MR to include a proposed fix for the issue of batting and pitching stats returning the same dataframe.

this means the fully qualified name will include the concrete class name (e.g. FangraphsBattingStatsTable.fetch) not the base class (e.g. FangraphsDataTable.fetch