Closed bdilday closed 2 years ago
Updated the MR to include a proposed fix for the issue of batting and pitching stats returning the same dataframe.
fetch
method from the abstract base class FangraphsDataTable
to the concrete classes FangraphsBattingStatsTable
, FangraphsFieldingStatsTable
, FangraphsPitchingStatsTable
this means the fully qualified name will include the concrete class name (e.g. FangraphsBattingStatsTable.fetch
) not the base class (e.g. FangraphsDataTable.fetch
<locals>
) instead of just the name. this means it will be e.g. FangraphsBattingStatsTable.fetch
instead of fetch
This adds a CI stage to illustrate the problem mentioned here https://github.com/jldbc/pybaseball/issues/267 https://github.com/jldbc/pybaseball/issues/221 namely that when the cache is enabled, the call to get the fangraphs batting and pitching stats return the same dataframe.