search

jldbc / pybaseball

Pull current and historical baseball statistics using Python (Statcast, Baseball Reference, FanGraphs)
MIT License
1.26k stars 333 forks source link

PyPi still using release 2.2.1 #281

Closed tjburch closed 1 year ago

tjburch commented 2 years ago

If you want the fresh 2.2.3, you'll have to install from the repo.

Brought up in the devs slack but just wanted to make an issue about it so we could remember/track it, and so it'd be out there in the public too. Not sure what needs to be done workflow-wise here but just keeping it on the radar.

bdilday commented 1 year ago

I just noticed that the deploy stage of the CI failed https://github.com/jldbc/pybaseball/actions/runs/2584633111 The logs have expired so not sure why. Maybe we could bump to 2.2.4 and try to release to find out what the error was?

tjburch commented 1 year ago

Good catch - @schorrm are you able to do that?

schorrm commented 1 year ago

Yes. Will do today

tjburch commented 1 year ago

I think we just need to bump the number here: https://github.com/jldbc/pybaseball/blob/9c0939020659b1d015f429031fce7a74923e9f16/setup.py#L22

tjburch commented 1 year ago

Updated. Tried rerunning the most recent 2.2.4 release workflow but still got the failure. I think it's just re-running the action as-is, without picking up the newest file change. Which means we hopefully just need to manually set off another call to that workflow. Worst case scenario, change setup.py to 2.2.5 and have yet another release.

tjburch commented 1 year ago

Success!