Closed zach-hopkins closed 1 year ago
Looks good.
Hey, thanks Zach, this is a clever addition to make this more useful.
Agree with @schorrm on moving the argument to the end. I added a review about a docstring so we know what all can be put there.
For the test, make sure this one still runs with the default value, then add a second just like it for a different option of view
.
For the docs, just add a note in this file with the alternate options for views.
Thanks again!
Hey, thanks Zach, this is a clever addition to make this more useful.
Agree with @schorrm on moving the argument to the end. I added a review about a docstring so we know what all can be put there.
For the test, make sure this one still runs with the default value, then add a second just like it for a different option of
view
.For the docs, just add a note in this file with the alternate options for views.
Thanks again!
No problem! Added the changes, let me know if all looks right. Works well on my end. 6d36b9c
LGTM for me
And also me. Seems pointless to run tests right now since they're all broke anyway so smashing that merge button.
Thanks a ton @zach-hopkins!
Proposed feature which simply adds an argument to the "pitcher_fielding" statcast pull in order to allow for "view" changes (options are: Fielder, Fielding Team, Batting, Batting Team, Pitcher). Helpful for pulling OOA and RAA for defense behind a particular pitcher and retrieving team fielding information. Set default to previous hardcode "Fielder"