update chadwick register access

jldbc / pybaseball

Pull current and historical baseball statistics using Python (Statcast, Baseball Reference, FanGraphs)

MIT License

1.18k stars 323 forks source link

update chadwick register access #309

Closed bdilday closed 1 year ago

bdilday commented 1 year ago

Updates the reading of the chadwick register from read people files from the chadwickbureau. The register has changed file format from one file containing all people, to several files, e.g. people-0.csv.

This PR updates code to

load the zip archive of chadwickbureau/register
search the zip archive for people*.csv
- instead of assuming path people.csv
read them all into a dataframe

closes https://github.com/jldbc/pybaseball/issues/308

schorrm commented 1 year ago

LGTM

tjburch commented 1 year ago

@bdilday can you re-up with master again to get the test updates from #318?

tjburch commented 1 year ago

Thanks!