search

jldbc / pybaseball

Pull current and historical baseball statistics using Python (Statcast, Baseball Reference, FanGraphs)
MIT License
1.18k stars 323 forks source link

Add function to calculate vertical approach angle for Statcast Dataframes #327

Open GMarsh0218 opened 1 year ago

GMarsh0218 commented 1 year ago

I added a function that calculates vertical approach angle using the formula from this fangraphs article to statcast_utils.py.

tjburch commented 1 year ago

Thanks! Nice add, definitely useful. Overall lgtm, just one comment and one clarification.

GMarsh0218 commented 1 year ago

I'm sorry, I don't understand what you want me to fix.

tjburch commented 1 year ago

What isn't clear?

tjburch commented 1 year ago

Hey @GMarsh0218, is there anything in the code review that I can help to clarify? This is a nice addition that I'd be very happy to see merged

GMarsh0218 commented 1 year ago

I didn't understand what you meant by "just one comment and one clarification." Do you want me to add more comments to the code?

tjburch commented 1 year ago

Oh, I see, my review was stuck in Pending and didn't get submitted. You should see them in-line now. Sorry about that.