jldbc / pybaseball

Pull current and historical baseball statistics using Python (Statcast, Baseball Reference, FanGraphs)
MIT License
1.18k stars 323 forks source link

Scrape Team-level "Batting Against" stats from Baseball-Reference #328

Open TK2575 opened 1 year ago

TK2575 commented 1 year ago
TK2575 commented 1 year ago

Is there anyone who can assist in debugging or re-running the failed check on this PR? Looks like python -m scripts.statcast_timing took longer than 30 seconds, causing the failure result. I don't know how relevant this is, but I haven't been able to reproduce a run locally greater than 18 seconds. Moreover, my changes shouldn't be utilizing or impacting statcast calls, hence why I was hoping to see how a second run performed. However, I do not see the option to re-run in any of the areas where the GitHub docs indicate, likely indicating I don't have permissions to do so.

tjburch commented 1 year ago

Yeah, that one just kind of trips randomly sometimes when scraping takes longer than usual. Just manually reran.

TK2575 commented 1 year ago

I'd have a few other years tested

I'm glad you mentioned this - trying against some older seasons demonstrated different data patterns than the expectations from newer seasons. I'll make the appropriate adjustments.

TK2575 commented 1 year ago

Thank you @tjburch for your thorough review - changes pushed and ready for re-review.

TK2575 commented 1 year ago

@tjburch looks like the timing test needs a re-run again

TK2575 commented 1 year ago

Switched to draft until I address the team name format diff