jldbc / pybaseball

Pull current and historical baseball statistics using Python (Statcast, Baseball Reference, FanGraphs)
MIT License
1.25k stars 333 forks source link

Raise threshold on statcast_timing #341

Open tjburch opened 1 year ago

tjburch commented 1 year ago

Timing failing regularly, lately it's been taking ~33 seconds. Figured I'd add a 5 sec buffer from that 33 so set to 38.

tjburch commented 1 year ago

Just to confirm, 3.10 test eclipsed 30 sec but still passed here:


Run python -m scripts.statcast_timing
This is a large query, it may take a moment to complete

  0%|          | 0/10 [00:00<?, ?it/s]
 10%|█         | 1/10 [00:11<01:39, 11.11s/it]
 20%|██        | 2/10 [00:11<00:40,  5.00s/it]
 30%|███       | 3/10 [00:12<00:20,  2.95s/it]
 40%|████      | 4/10 [00:14<00:15,  2.51s/it]
 50%|█████     | 5/10 [00:15<00:10,  2.03s/it]
 60%|██████    | 6/10 [00:16<00:06,  1.56s/it]
 70%|███████   | 7/10 [00:21<00:08,  2.86s/it]
 80%|████████  | 8/10 [00:24<00:05,  2.75s/it]
 90%|█████████ | 9/10 [00:26<00:02,  2.64s/it]
100%|██████████| 10/10 [00:30<00:00,  3.19s/it]
100%|██████████| 10/10 [00:30<00:00,  3.09s/it]
query took  31.3 seconds (expected less than  38.0)