download_lahman() pull OLD Lahman dataset (baseballdatabank-2017.1)

jldbc / pybaseball

Pull current and historical baseball statistics using Python (Statcast, Baseball Reference, FanGraphs)

MIT License

1.26k stars 335 forks source link

download_lahman() pull OLD Lahman dataset (baseballdatabank-2017.1) #57

Closed prs-watch closed 4 years ago

prs-watch commented 5 years ago

When I execute pybaseball.download_lahman(), following is happened.

This problem was already fixed by this commit. But I guess this fix maybe not on released module to PyPI.
(I checked 1.0.5 and 1.0.7, but both set baseballdatabank-2017.1.zip to lahman.url).

Could you check how released module is right now, and fix this problem?

schorrm commented 5 years ago

PyPI is just behind. If you clone the repo and install it won't be an issue

prs-watch commented 5 years ago

Thanks @schorrm !

If you clone the repo and install it won't be an issue

Yeah I already solved this problem by that way a few days ago. master branch worked well.

PyPI is just behind.

Why does this happen? Is PyPI module not synchronized master branch's version?

schorrm commented 4 years ago

PyPI will be synced to the releases soon after the CI is ready