search

jlebon / textern

A Firefox add-on for editing text in your favourite external editor!
GNU General Public License v3.0
138 stars 21 forks source link

Code cleanup #45

Closed phdru closed 5 years ago

jlebon commented 5 years ago

Thanks! Can you just make the commit message titles lower case?

Random aside: looks like your email might not be associated with your GitHub username? E.g. GitHub says "Oleg Broytman authored and phdru committed" on the first two commits.

phdru commented 5 years ago

Thanks! Can you just make the commit message titles lower case?

Completely lower case or title case?

Style(native): fix flake8 warnings

or

style(native): fix flake8 warnings

???

Random aside: looks like your email might not be associated with your GitHub username? E.g. GitHub says "Oleg Broytman authored and phdru committed" on the first two commits.

Ah, thank you for spotting! That's my work email. Will fix it.

jlebon commented 5 years ago

style(native): fix flake8 warnings

That one. :)

phdru commented 5 years ago

Done. :smiley:

jlebon commented 5 years ago

Awesome, thanks!