jlebon / textern

A Firefox add-on for editing text in your favourite external editor!
GNU General Public License v3.0
138 stars 21 forks source link

Ensure the native->web text preserves spacing #80

Closed alex-ozdemir closed 1 year ago

alex-ozdemir commented 2 years ago

Two changes:

This patch is motivated by my use of GMail.

alex-ozdemir commented 2 years ago

This probably closes #63.

alex-ozdemir commented 2 years ago

Paging @jlebon. What do you think of this change?

alex-ozdemir commented 2 years ago

Paging @jlebon again.

jlebon commented 1 year ago

Can you describe in more details what issues you're seeing?

alex-ozdemir commented 1 year ago

Hi Jonathan,

Of course! I should have to begin with.

I use textern most in GMail, to write essentially all of my email. It seems that the text in the external editor -> GMail textbox pipeline gets mangled.

Specifically, I see two phenomena:

This seems somewhat GMail-specific. In github (e.g., this text box) I have no such issues.

The approach taken in this patch is to write to the inner-HTML directly, in a way that GMail seems to understand.

However, perhaps we should restrict the patch to only modify interactions with GMail? (similar to interactions with Slack?)

Cheers, Alex

P.S. Thank you for creating this extension. It really has improved my email experience a lot :).

alex-ozdemir commented 1 year ago

Okay, I went ahead and scoped this to GMail message bodies.