More Cards - Githubissues

jleclanche / fireplace

A Hearthstone simulator in Python

https://hearthsim.info

GNU Affero General Public License v3.0

673 stars 150 forks source link

More Cards #460

Closed shinoi2 closed 6 years ago

shinoi2 commented 6 years ago

Knowed issue: Some tests will fail under special circumstances.

test_medivh cost(2) summon ”Wild Pyromancer“ or "Sorcerer's Apprentice”, test will be failed.
"Molten Giant" cost 25 -> 20 make some test failed.
prepare_game() will cause an unexpected error.

tonyyyye commented 6 years ago

test cases failed by CI. Can you fix those or can you roll back to some previous submission that may pass this? BTW flake8 and ci can be intergrated into your branch.

shinoi2 commented 6 years ago

flake8 failed, it checks my code style and includes a lot of files. I don't cleanly know how to fix it.
test case failed, I will fix it in this weekend.

tonyyyye commented 6 years ago

When i have time i will help to check the flake8 issue. Thanks for your great contribution.

jleclanche commented 6 years ago

@shinoi2 @tonyyyye sorry I'm quiet here, it's a busy week... I'll get to this pr

shinoi2 commented 6 years ago

@jleclanche This PR is very dirty, do I need to organize it into several patches to submit? like: https://github.com/shinoi2/fireplace/commit/213222215162d52ccde0ed6c6a3a5c07948ccd0f

tonyyyye commented 6 years ago

We've decided to split this PR into several smaller ones which are clear and easy for you to check and merge.