search

jleclanche / python-bna

Python implementation of the mobile Blizzard Authenticator (TOTP)
https://eu.battle.net/support/en/article/24520
MIT License
256 stars 38 forks source link

Fix formatting authenticator serial #33

Closed cbespin closed 2 years ago

cbespin commented 2 years ago

Adressing #32 this commit deletes the hyphens in the serial formatter. The official app does not provide a serial for registration anymore, so parsing might have changed on Blizzard's side. Only when recovering Blizzard gives a serial, but using the supplied copy function gives a string without hyphens as well.

Test for formatting the serial has been adapted (basically just changing region code to uppercase now)

jiawen commented 2 years ago

Ha yeah I had the same issue trying to set this up for the first time on the battle.net website. I thought python-bna was broken but it turns out removing the hyphens worked great.

jleclanche commented 2 years ago

Merged in b6cb3f8191eebc81af75c522f92775391dd264e3