search

jledentu / vue-finder

📁 A Vue.js component to display hierarchical data (like the MacOS X finder)
https://vue-finder.netlify.app
MIT License
160 stars 16 forks source link

fix: do not trap focus when virtualize: true #215

Closed jledentu closed 11 months ago

jledentu commented 11 months ago

When virtualize="true", we force the focus on the last expanded element of the tree after having updated the displayed range on a list.

So it can cause bugs where an active element of an app will lose focus if the Finder is updated.

This PR fixes this.

codecov[bot] commented 11 months ago

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (fad3f78) 93.36% compared to head (85ac00c) 95.96%. Report is 1 commits behind head on 2.x.

Files Patch % Lines
src/components/FinderList.vue 47.05% 9 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## 2.x #215 +/- ## ========================================== + Coverage 93.36% 95.96% +2.59% ========================================== Files 10 10 Lines 1704 1710 +6 Branches 160 179 +19 ========================================== + Hits 1591 1641 +50 + Misses 112 69 -43 + Partials 1 0 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 11 months ago

:tada: This PR is included in version 2.2.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: