search

jleeson / rollup-plugin-html-literals

A Rollup plugin to minify html template literals
MIT License
9 stars 0 forks source link

Enable support for rollup v3 #2

Closed dgrammatiko closed 2 years ago

dgrammatiko commented 2 years ago

Also this PR does:

jleeson commented 2 years ago

@dgrammatiko thanks for opening a pull request, while I agree rollup v3 support needs to be added. I still would like to keep the package supporting a CJS and ESM build. If you want to adjust the PR to keep the builds as is while adding v3 support I can merge the PR.

jleeson commented 2 years ago

Sorry to be picky, rather than adding a new build.js script, it would be preferably to keep the existing build pipeline with rollup. The only thing that should need to change for rollup v3 support is just updating dependencies, dropping v1 if there is an api incompatibility, and updating the peerDependencies versions. Is there a reason you want to drop the existing system and just add a script to copy the file over?

dgrammatiko commented 2 years ago

it would be preferably to keep the existing build pipeline with rollup.

Then you have to wait till rollup-plugin-esbuild is merged so that the bundling could work. I don't mind closing this PR and let you update the deps when the rollup-plugin-esbuild is v3 compatible

jleeson commented 2 years ago

Since the rollup dependencies are devDependencies they are not required for adding v3 support, so the devDependencies can remain the same, and rollup v3 can still be supported. If you want to make the changes you can otherwise I dont mind pushing an update with this. (This is how i added rollup v3 support to rollup-plugin-import-css)

jleeson commented 2 years ago

Thanks for taking care of the support for Rollup v3 @dgrammatiko, v1.1.6 is published on npm.