search

jlegewie / zotfile

Zotero plugin to manage your attachments: automatically rename, move, and attach PDFs (or other files) to Zotero items, sync PDFs from your Zotero library to your (mobile) PDF reader (e.g. an iPad, Android tablet, etc.), and extract PDF annotations.
3.95k stars 281 forks source link

"Rename and Move" only moves the first highlight/annotation #593

Closed tzshi closed 2 years ago

tzshi commented 2 years ago

Hi,

After updating to Zotero 6, I noticed that if I want to rename and move a stored file with annotations to a linked file through zotfile, it only moves the first annotation and the rest of the annotations stay in the original file. (Fortunately no annotation was lost :) )

Maybe this is related to @dstillman 's recent update for Zotero 6 compatibility?

Thanks!

dstillman commented 2 years ago

What do you mean by "the rest of the annotations stay in the original file"? It's moving the file, so isn't there only one file?

dstillman commented 2 years ago

And to be clear, are you talking about Zotero annotations, made in the Zotero PDF reader?

tzshi commented 2 years ago

Yes, these are Zotero annotations made in the new Zotero PDF reader.

And after clicking "Rename and Move" I ended up with two files, a stored file (the original one) with all annotations except the first, and a new linked file with only the first annotation.

dstillman commented 2 years ago

Can you provide a Debug ID for that? You shouldn't end up with two files at all.

tzshi commented 2 years ago

Thanks for the instruction to generate a Debug ID. Here it is: D1426878277

Actually I noticed that after this operation, the original file icon will appear gray and if I double click again (is this syncing from Zotero?), I will see a file with all but the first annotation.

tzshi commented 2 years ago

(In the attached debug ID, I used a fresh file with two annotations (highlights) on the first page.)

tzshi commented 2 years ago

And I also tried "Rename and Move" a "blank" file without any annotations, and in that case, the renaming was successful and I ended up with only one file.

dstillman commented 2 years ago

Does it happen with all other third-party extensions disabled?

tzshi commented 2 years ago

Yes, I just tried disabling all other extensions and still the same result.

dstillman commented 2 years ago

OK, I can reproduce. Investigating.

dstillman commented 2 years ago

OK, sorry, I didn't test ZotFile properly after a recent Zotero change. Should be fixed once the linked PR is merged.

tzshi commented 2 years ago

Thank you so much for fixing this so fast!

jlegewie commented 2 years ago

I released a new version (5.1.1) with the patch yesterday so it should be fixed.