jlegewie / zotfile

Zotero plugin to manage your attachments: automatically rename, move, and attach PDFs (or other files) to Zotero items, sync PDFs from your Zotero library to your (mobile) PDF reader (e.g. an iPad, Android tablet, etc.), and extract PDF annotations.
4.05k stars 282 forks source link

128 chars limit in the "Use subfolder defined by" function #628

Open xhchrn opened 2 years ago

xhchrn commented 2 years ago

Dear all, I have been using Zotero + Zotfile + OneDrive combination quite happily to sync everything. But today when I tried to save a publication from web I found Zotfile cannot move the attachment file to the correct folder defined by my "Use subfolder defined by" setting.

My Zotfile Settings

Custom Location: /Path/to/my/OneDrive/zotero
[checked] Use subfolder defined by: {%a - }{%t}{ - %w}

The report of the publication for which I ran into issues

  *
        Reconciling modern machine-learning practice and the classical
        bias-variance trade-off

    Type    Journal Article
    Author  Mikhail Belkin
    Author  Daniel Hsu
    Author  Siyuan Ma
    Author  Soumik Mandal
    Date    2019-08-06
    Library Catalog     pnas.org (Atypon)
    URL     https://www.pnas.org/doi/abs/10.1073/pnas.1903070116
    Accessed    9/24/2022, 12:41:52 PM
    Extra   Publisher: Proceedings of the National Academy of Sciences
    Volume  116
    Pages   15849-15854
    Publication     Proceedings of the NASSSSSSSSSSSSSS
    DOI     10.1073/pnas.1903070116 <http://doi.org/10.1073/pnas.1903070116>
    Issue   32
    Date Added  9/24/2022, 12:41:52 PM
    Modified    9/24/2022, 1:00:46 PM

          Attachments

      o Belkin et al_2019_Reconciling modern machine-learning practice
        and the classical bias-variance.pdf

My Observations

So the issue seems to be that, with the {%a - }{%t}{ - %w} setting for the subfolder definition, the combined subfolder for this pub is

Belkin et al - Reconciling modern machine-learning practice and the classical bias-variance - Proceedings of the NASSSSSSSSSSSSSS

which has 129 chars. If I delete one S from the Publication field, shortening the subfolder name to 128 chars, then the PDF attachment can be correctly moved to the subfolder.

I am on Windows 11, version 22H2. I am not sure this is a Zotfile issue or the Windows'. Any suggestions?

Best