Update language configuration

jlelong / vscode-latex-basics

LaTeX grammars for Visual Studio Code

MIT License

19 stars 10 forks source link

Update language configuration #16

Closed JaMeZ-B closed 2 years ago

JaMeZ-B commented 2 years ago

I propose the following two small changes:

make $...$ auto closing. IMHO, this is not something, that users should be actively discouraged from using (in contrast to $$...$$).
add { to autoclosebefore. This is useful for adding optional parameters to already existing code, in particular for adding parameters to \usepackage{...}

Cheers and keep up the good work!

jlelong commented 2 years ago

I agree with adding { to autoclosebefore. I am more reserved with auto closing $ as there have been a lot of discussions in LaTeX-Workshop on this, see for instance https://github.com/James-Yu/LaTeX-Workshop/issues/365. Fiddling with auto closing for $ requires a lot of care and needs heavy testing. You should rather define a snippet to insert $ ... $ with the cursor between the $.

jlelong commented 2 years ago

Because of microsoft/vscode#143187, it is very difficult to test change in the language definition reliably. In particular, I want to make sure it does harm LaTeX-Workshop. I will wait until microsoft/vscode#143187 is closed to deal with this PR.