search

jlemke / pathfinderProject

A website where I can save my Pathfinder character sheets and GM notes.
0 stars 0 forks source link

Week 8 Code Review #10

Open hallahhussien opened 7 years ago

hallahhussien commented 7 years ago

Design/Code Review 2

Project: Blog Site

Developer: Joe L

Reviewer: Hallah

Category Criteria Analysis/Comments
Running application
Describe the application functionality that has been built and is working. Everything works and I am so impressed with it!
What is good? Everything is good in my opinion, it works and the code is clean!
What could be improved? Making the user side prettier
Unit Tests
What are the code coverage statistics? Wasn't Demo'd
Are @Before/@BeforeClass/@After/@AfterClass used to reduce redundant code? yes
JSPs
Is templating used to eliminate rundandant code(for example, header.jsp, footer.jsp, etc.) yes
What is good? It is very organized!
What could be improved? Again, just user side stuff
Code quality
Are methods single-purpose? yes
Are classes appropriately-sized classes (no monster classes)? yes
Are the same lines of code repeated at all? no
Do any classes perform very similar functions that could be candidates for super/subclass relationships? no
Are any values hard-coded that should be in a properties file? no
Are variable names descriptive? I don't know if it's because I don't know the game or not but some abbreviations in the variables were confusing to me - but that's just me!
Are there many branches or loops that could be simplified or broken up into smaller methods? no
Do the DAOs use Hibernate? No hard-coded sql! yes
Has log4J been added? no
Are there logging statements in the code? no
Are appropriate logging levels used? Info, debug, error, for example. no
Are there any System.out.printlns in the code? no
Other comments/notes?
Web Service/API integration Which web service/api is being used? Not yet! but he expressed some ideas during discussion
Is the integration built? no
If so, evaluate the integration code. What is good? What could use improvement?
Independent research topic What is the developer's independent research topic? Said in discussion but not mentioned in the project plan
Has the topic been implemented in the project? no
If so, evaluate the implementation. What is good? What could use improvement?