jlengstorf / gatsby-intermediate

https://frontendmasters.com/courses/intermediate-gatsby/
MIT License
54 stars 48 forks source link

Code Highlighting is Broken with Upgraded Packages #12

Closed anindha closed 4 years ago

anindha commented 4 years ago

If I checkout at the revision https://github.com/jlengstorf/gatsby-intermediate/commit/d14378259b2ccd303d17c563c3148fb26af26a76, run yarn upgrade-interactive and run yarn workspace theme-dev develop syntax highlighting breaks.

jlengstorf commented 4 years ago

@anindha are you getting any errors? any extra info you can provide about what "breaks" means in this context is super helpful for tracking down the cause

thanks!

anindha commented 4 years ago

@jlengstorf The code no longer has syntax highlighting but there is no error message in the console. Please let me know if I can help in anyway.

mranthonysutton commented 4 years ago

Getting the same issues. I've even tried removing:

if (!codeProps) { return <pre {...props} />; }

To see if maybe it was just not returning due to having no props, but still not receiving anything. The code loads, but no props for the theme or any of the styles within the code block.

jlengstorf commented 4 years ago

hey, y'all! thanks for your patience

I just ran the upgrade to duplicate and it still shows syntax highlighting for me

here's what I did:

  1. cloned the repo
  2. checked out d143782
  3. ran yarn upgrade-interactive and selected all dependencies
  4. ran yarn outdated and noticed that not all dependencies had upgraded
  5. manually updated the remaining dependencies (see screenshots)
  6. ran yarn workspace theme-dev develop
Screen Shot 2020-05-28 at 9 55 47 AM Screen Shot 2020-05-28 at 9 55 58 AM

when I visit http://localhost:8000 I still see syntax highlighting:

Screen Shot 2020-05-28 at 9 57 28 AM

here's a screenshot of my terminal showing all deps up to date and only the packages updated

Screen Shot 2020-05-28 at 9 58 37 AM

if you're still hitting this issue, can you please send over a repo to look at?

for now, I'm going to close since the deps appear to upgrade successfully