search

jlengstorf / gatsby-remark-numbered-footnotes

A small plugin to change named footnotes to numbered footnotes in your Gatsby pages using Markdown.
16 stars 3 forks source link

Numbers not working in latest releases of remark #9

Closed jlengstorf closed 5 years ago

jlengstorf commented 5 years ago

Since https://github.com/syntax-tree/mdast-util-to-hast/pull/31, footnotes use node.label instead of node.identifier. This means that numbered footnotes aren't actually working right now.

An upstream fix is required, and the PR is open: https://github.com/zestedesavoir/zmarkdown/pull/362

As soon as that merges, we need to bump to the updated version and cut a new release of this plugin to fix. This will fix https://github.com/gatsbyjs/gatsby/issues/16578

ghost commented 5 years ago

remark-numbered-footnotes@1.1.0 seems to fix the problem. But for some reason I keep getting remark-numbered-footnotes@1.0.12 installed when I create a new Gatsby site, in spite of this plugin marking remark-numbered-footnotes@^1.0.1 as devDep. So it should include v1.1.0. Not sure why you need to bump the version of this plugin? Maybe someone could elaborate? Thanks!

ghost commented 5 years ago

Lockfile! Ofc! 🙈