search

jleonard2099 / LHG_CollegeBB

Lance Haffner Courtside College Basketball
GNU Affero General Public License v3.0
5 stars 0 forks source link

Tournament creation throws error #11

Closed jleonard2099 closed 1 year ago

jleonard2099 commented 1 year ago

Per Philip Lupi:

When entering to name each region they come up as To Be named. You have to space use the backspace key to delete then enter.

I believe the code for CBB was an older version than is current. Will update for this to match.

When complete and you hit Save and exit it crashes. Error#9 Line 3250 ADDTOURN.BAS

This is for the consolation setting. The wrong array name was being used. Corrected.

4 brackets. 4 teams each. It did appear to save. But when I went to view only the 4th region showed. The others showed no teams.

If I go to show brackets. Only 3 of 4 teams show. 4th team not there.

It did create a schedule but the first game listed is Game 1 winner vs Game 2 winner

I will revisit these issues as this feature was previously working but variable changes may have corrupted it.

jleonard2099 commented 1 year ago

Corrected issues with tournament play after several changes. Function to save tournament files was only used when editing, not when completing the tournament. Editing of tournament file was being called in the wrong conditions.

Still evaluating display of brackets but initial behavior in testing so far matches the original. Will need to do more testing with 4 brackets to confirm if this behavior is legacy or not.

jleonard2099 commented 1 year ago

Found where incorrect If/Then structure was clearing names of teams before saving file. Between this and some other edits to parameter passing, the main files get created and all teams can be reviewed.

The brackets still don't appear to be generated correctly. This will take more investigation.

jleonard2099 commented 1 year ago

All issues fixed and corrected now. Bracket management was indeed flawed with logic in a few places. Previous testing had only been for 1 / 2 regions. Several conditionals required updated. Also fixed inability to edit brackets after realizing it would just go back to the menu. This is because the edit function was not being called after initializing the data.

Lastly, updated bracket view to make sure it would draw lines in where missing. The routine for this was missing for 4 team bracket because of a misunderstanding with the original code.